-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miner should not dial client on restart #5210
Conversation
(assuming that there's some good reason that this is a draft) |
👍 It's a draft at the moment because I want to try to write some integration tests today to make sure the retry logic works |
313ae46
to
f25d874
Compare
6b713dc
to
e5ef95a
Compare
e5ef95a
to
1206154
Compare
Yesterday we performed a manual test. However I think this is a big improvement, and there is also improved logging so we can see exactly what the client and miner side of the data transfer are doing. So I favour merging this PR and then bubbling up improvements to graphsync as they are released. For future reference, to see all the relevant data transfer activity, the following log subsystems should be set at debug level:
|
…kts-miner-dont-dial-client Miner should not dial client on restart
Fixes #4991 #5211 #5224 #5268 #5038
It wasn't a small task to write an integration or testground test, so this should be tested manually: