Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-wallet: Add interactive mode #5219

Merged
merged 3 commits into from
Feb 5, 2021
Merged

lotus-wallet: Add interactive mode #5219

merged 3 commits into from
Feb 5, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 17, 2020

Nice for things like looking at decoded message params on a secureish device before passing to ledger

@magik6k
Copy link
Contributor Author

magik6k commented Dec 17, 2020

Example prompt:

ACTION: WalletSign - Sign a message/deal
ADDRESS: f1...
TYPE: message
Message JSON: {
  "Version": 0,
  "To": "f2...",
  "From": "f1....",
  "Nonce": 3,
  "Value": "0",
  "GasLimit": 427524,
  "GasFeeCap": "1637334214",
  "GasPremium": "11372",
  "Method": 2,
  "Params": "hEIAY0AAQK==",
  "CID": {
    "/": "baf..."
  }
}
Value: 0 FIL
Max Fees: 0.069999999997297 FIL
Max Total Cost: 0.069999999997297 FIL
Method: Propose
Params: {
  "To": "f099",
  "Value": "0",
  "Method": 0,
  "Params": null
}
        MultiSig Proposal Value: 0 FIL
        MultiSig Proposal Hex Params: 
        MultiSig Proposal Method: Send
        MultiSig Proposal Params: {}

Accept the above? (Yes/No):

@magik6k magik6k requested a review from arajasek January 20, 2021 17:46
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit (and needs rebasing).

Might also be good to docs folks attention?

cmd/lotus-wallet/interactive.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit dc6392d into master Feb 5, 2021
@magik6k magik6k deleted the feat/interactive-wallet branch February 5, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants