Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storageadapter: Look at precommits on-chain since deal publish msg #5398

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jan 21, 2021

This might fix some of the test hangs we see in CI

@magik6k magik6k requested a review from dirkmc January 21, 2021 11:24
@magik6k magik6k self-assigned this Jan 21, 2021
@magik6k magik6k mentioned this pull request Jan 21, 2021
3 tasks
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I like the way you made it more testable 👍

Just a couple of nits

markets/storageadapter/provider.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit e77df95 into master Jan 21, 2021
@magik6k magik6k deleted the fix/market-precommit-diff branch January 21, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants