Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary database reads in validation check #5540

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Remove unnecessary database reads in validation check #5540

merged 1 commit into from
Feb 5, 2021

Conversation

austinabell
Copy link
Contributor

Is there any possible way that this genesis will ever be nil and it would otherwise load from store?

magik6k
magik6k approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Reading through the code I don't think there's any case where this can be nil

@magik6k magik6k merged commit 9f546c2 into filecoin-project:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinabell @magik6k