Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build-lotus-soup ci job #5554

Merged
merged 3 commits into from
Feb 8, 2021
Merged

fix build-lotus-soup ci job #5554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
764a08b
fix testplans build
nonsense Feb 8, 2021
cc91eab
fix lr.Datastore interface to include context
nonsense Feb 8, 2021
891971e
circleci: add task to get latest master for lotus
nonsense Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testplans/lotus-soup/rfwp/html_chain_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func FetchChainState(t *testkit.TestEnvironment, m *testkit.LotusMiner) error {
return c.Code, nil
}

return cli.ComputeStateHTMLTempl(file, tipset, stout, true, getCode)
return cli.ComputeStateHTMLTempl(file, tipset, stout, getCode)
}()
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion testplans/lotus-soup/testkit/role_miner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func PrepareMiner(t *TestEnvironment) (*LotusMiner, error) {
return nil, err
}

ds, err := lr.Datastore(context.Background(), "/metadata")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't using lotus from master - https://github.com/filecoin-project/lotus/blob/master/node/repo/interface.go#L58

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, sorry about this.

The problem was that build-lotus-soup was missing a step to go get github.com/filecoin-project/lotus@master and this was indeed building an outdated commit from master.

I've added the step, so now on every CI run, we build against Lotus from master, which is what we want.

ds, err := lr.Datastore("/metadata")
if err != nil {
return nil, err
}
Expand Down