Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: Config to disable owner/worker address fallback #5620

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 17, 2021

TODO:

  • Test

@magik6k magik6k added the area/mining Area: Mining label Feb 17, 2021
@magik6k magik6k changed the title miner: Config to disable owner/worker addcess fallback miner: Config to disable owner/worker address fallback Feb 25, 2021
@magik6k magik6k force-pushed the feat/disable-owner-worker-fallback branch from 21dbf58 to 305c2ec Compare March 8, 2021 20:33
@magik6k magik6k changed the base branch from master to next March 8, 2021 20:49
@magik6k magik6k marked this pull request as ready for review March 8, 2021 21:24
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// sent automatically
DisableOwnerFallback bool
// DisableWorkerFallback disables usage of the worker address for messages
// sent automatically if control addresses are configured, even if those
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// DisableWorkerFallback disables usage of the worker address for messages
// sent automatically, if control addresses are configured.
// A control address that doesn't have enough funds will still be chosen over the worker address if this flag is set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(found the comment confusing)

@magik6k magik6k merged commit 0527494 into next Mar 10, 2021
@magik6k magik6k deleted the feat/disable-owner-worker-fallback branch March 10, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mining Area: Mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants