Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] FIP0013 integration for Actors v5 #5769

Closed
wants to merge 17 commits into from
Closed

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 10, 2021

Currently this is pulling in filecoin-project/filecoin-ffi#169, filecoin-project/go-paramfetch#13 and filecoin-project/specs-actors#1381, and implementing some plumbing logic for proof aggregation

TODO:

  • implement mock proof api to unblock some integration work
  • Write some unit tests for CommitBatcher
  • Write an integration test for commit batching
    • Test edge-cases
      • One porep fails
      • One commit expires? (deal start?)
      • Batch fails for whatever reason (e.g. out of gas)
  • Integrate nicer proof aggregation apis when they land in filecoin-ffi
  • Expose CommitBatcher in the miner api / cli (similar to termination batcher)
  • Test in pond
  • Switch to v5 actors when ready in specs-actors

@arajasek arajasek mentioned this pull request Apr 7, 2021
@magik6k magik6k mentioned this pull request Apr 12, 2021
@jennijuju jennijuju linked an issue Apr 13, 2021 that may be closed by this pull request
@BigLep BigLep changed the title [WIP] Actors v4 [WIP] Actors v5 Apr 29, 2021
@BigLep BigLep added this to the Network v13 Integrations milestone Apr 29, 2021
@BigLep BigLep changed the title [WIP] Actors v5 [WIP] FIP0013 integration for Actors v5 May 3, 2021
@BigLep
Copy link
Member

BigLep commented May 3, 2021

I updated the name to discuss FIP0013 integration as I think that's the focus.

@jennijuju jennijuju mentioned this pull request May 4, 2021
80 tasks
@arajasek arajasek mentioned this pull request May 12, 2021
7 tasks
@arajasek
Copy link
Contributor

Closed in favor of #6235

@arajasek arajasek closed this May 12, 2021
@Kubuxu Kubuxu deleted the feat/actors-v4 branch November 25, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate v5 actor
3 participants