Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return buffers after canceling badger operation #5796

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

Stebalien
Copy link
Member

In theory, Delete/Put could fail. If it does, we'll return the buffers to the pool before we're really done with them.

In practice, this is almost certainly not an issue as badger shouldn't use the buffer unless we flush. But I feel slightly safer this way.

In theory, Delete/Put could fail. If it does, we'll return the buffers
to the pool before we're really done with them.

In practice, this is almost certainly not an issue as badger shouldn't
_use_ the buffer unless we flush. But I feel slightly safer this way.
@magik6k magik6k merged commit 06aaa66 into master Mar 12, 2021
@magik6k magik6k deleted the fix/return-after-cancel branch March 12, 2021 10:13
@magik6k magik6k mentioned this pull request Apr 13, 2021
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants