Robust message management #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
added
the
team/ignite
7 tasks
Kubuxu
force-pushed
the
epic/robust-message-management
branch
3 times, most recently
from
5523500
to
8ac4bfa
Compare
|
TODO:
|
Kubuxu
changed the title
|
@Kubuxu could you please add a feature to handle miner creation messages? |
|
blocked by v1 api |
|
please have the doc ready before landing in master. filecoin-project/lotus-docs#193 |
Kubuxu
force-pushed
the
epic/robust-message-management
branch
from
430f6a9
to
2d1d522
Compare
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
This introduces message prototypes to applicable API endpoints, which allows us to invert control of message sending and give the user a chance to intervene with an interactive ui. Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
epic/robust-message-management
branch
from
3eb30d0
to
d777680
Compare
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
epic/robust-message-management
branch
from
d91cafa
to
18cbdcf
Compare
whyrusleeping
approved these changes
May 7, 2021
There was a problem hiding this comment.
High-ish level walkthrough with @Kubuxu and theres nothing glaring. The message checking logic looks good, but could probably use another set of eyes looking in depth just at that.
I did not really review the terminal UI logic, but I assume any issues there will be fleshed out quickly (and arent make or break for the software)
|
Squinted at the message checking logic, and SGWM. FISITIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5869.
This is the staging branch for the robust message management epic undertaken by @Kubuxu and @vyzo (with cameo appearances by @raulk).
PRs: