Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take latency into account when making interactive deals #5876

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 24, 2021

In manual testing this results in drastically higher success rate for me.

After setting max 150ms latency, making 20 deals, 12 got rejected immediately, 8 started transferring with decent speed right away.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@magik6k magik6k merged commit 5d44ed0 into master Mar 24, 2021
@magik6k magik6k deleted the feat/interactive-deal-latency branch March 24, 2021 22:04
@magik6k magik6k mentioned this pull request Apr 13, 2021
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants