-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix success handling in Retreival #5921
Conversation
cli/client.go
Outdated
if evt.Status == retrievalmarket.DealStatusCompleted { | ||
afmt.Println("Success") | ||
} else { | ||
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted", retrievalmarket.DealStatuses[evt.Status]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted", retrievalmarket.DealStatuses[evt.Status]) | |
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted\n", retrievalmarket.DealStatuses[evt.Status]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestCLIDealFlow
fails
@magik6k @dirkmc The failing test looks flaky as it works for me locally:
|
80a9fce
to
35a466f
Compare
(rebased on latest master) |
For #5895.