Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix success handling in Retreival #5921

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Conversation

aarshkshah1992
Copy link
Contributor

For #5895.

cli/client.go Outdated
if evt.Status == retrievalmarket.DealStatusCompleted {
afmt.Println("Success")
} else {
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted", retrievalmarket.DealStatuses[evt.Status])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted", retrievalmarket.DealStatuses[evt.Status])
afmt.Printf("saw final deal state %s instead of expected success state DealStatusCompleted\n", retrievalmarket.DealStatuses[evt.Status])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCLIDealFlow fails

@aarshkshah1992
Copy link
Contributor Author

@magik6k @dirkmc The failing test looks flaky as it works for me locally:

2021-04-02T16:45:59.432+0530	INFO	dt-impl	impl/impl.go:207	stop data-transfer module
2021-04-02T16:45:59.432+0530	WARN	events	events/events.go:111	not restarting listenHeadChanges: context error: context canceled
2021-04-02T16:45:59.433+0530	INFO	graphsync	impl/graphsync.go:309	Graphsync ReceiveError from 12D3KooWDsr3wjMb7DQwc31kyWPGba5RL9PkzTXsnj3PBNRMP4zs: stream reset
2021-04-02T16:45:59.435+0530	ERROR	miner	miner/miner.go:335	failed to submit newly mined block: handler: websocket connection closed
2021-04-02T16:45:59.435+0530	INFO	dt-impl	impl/impl.go:207	stop data-transfer module
2021-04-02T16:45:59.435+0530	ERROR	miner	miner/miner.go:226	failed to get best mining candidate: RPC client error: sendRequest failed: websocket routine exiting
2021-04-02T16:45:59.435+0530	WARN	events	events/events.go:106	listenHeadChanges quit
2021-04-02T16:45:59.435+0530	WARN	events	events/events.go:111	not restarting listenHeadChanges: context error: context canceled
2021-04-02T16:45:59.436+0530	WARN	events	events/events.go:106	listenHeadChanges quit
2021-04-02T16:45:59.436+0530	WARN	events	events/events.go:111	not restarting listenHeadChanges: context error: context canceled
--- PASS: TestCLIDealFlow (16.88s)
PASS


@magik6k magik6k added the team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs label Jun 3, 2021
@magik6k magik6k force-pushed the fix/retrieve-success-handling branch from 80a9fce to 35a466f Compare June 4, 2021 19:41
@magik6k
Copy link
Contributor

magik6k commented Jun 4, 2021

(rebased on latest master)

@magik6k magik6k enabled auto-merge June 4, 2021 19:44
@magik6k magik6k merged commit 91c87b7 into master Jun 4, 2021
@magik6k magik6k deleted the fix/retrieve-success-handling branch June 4, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants