Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 4857: show help for set-addrs #5943

Merged
merged 3 commits into from
Apr 10, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cmd/lotus-storage-miner/actor.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,22 @@ var actorSetAddrsCmd = &cli.Command{
Usage: "set gas limit",
Value: 0,
},
&cli.BoolFlag{
Name: "unset",
Usage: "unset address",
Value: false,
},
},
Action: func(cctx *cli.Context) error {
args := cctx.Args().Slice()
unset := cctx.Bool("unset")
if len(args) == 0 && !unset {
return cli.ShowSubcommandHelp(cctx)
}
if len(args) > 0 && unset {
return fmt.Errorf("unset can only be used with no arguments")
}

nodeAPI, closer, err := lcli.GetStorageMinerAPI(cctx)
if err != nil {
return err
Expand All @@ -70,7 +84,7 @@ var actorSetAddrsCmd = &cli.Command{
ctx := lcli.ReqContext(cctx)

var addrs []abi.Multiaddrs
for _, a := range cctx.Args().Slice() {
for _, a := range args {
arajasek marked this conversation as resolved.
Show resolved Hide resolved
maddr, err := ma.NewMultiaddr(a)
if err != nil {
return fmt.Errorf("failed to parse %q as a multiaddr: %w", a, err)
Expand Down