Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to do better padding on pieces being written into sectors #5988

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

whyrusleeping
Copy link
Member

No description provided.

@ribasushi
Copy link
Collaborator

Relevant PR's to make this all work:

diff --git a/go.mod b/go.mod
index 503e95c5d..2d2548ccc 100644
--- a/go.mod
+++ b/go.mod
@@ -31 +31 @@ require (
-       github.com/filecoin-project/go-commp-utils v0.0.0-20201119054358-b88f7a96a434
+       github.com/filecoin-project/go-commp-utils v0.1.1-0.20210407220142-9d7f7aaf8c9c
@@ -35 +35 @@ require (
-       github.com/filecoin-project/go-fil-markets v1.1.9
+       github.com/filecoin-project/go-fil-markets v1.1.10-0.20210407195421-65658e33ed64

filecoin-project/go-fil-markets#536
filecoin-project/go-commp-utils#3

Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tested extensively on nerpanet:

  • Storage of an 4x artificially padded data filling entire sector
  • Storage of a 2x artificially padded data filling half of sector, with the other half being auto-filled by CC
  • Retrieval from a separate node from the saved-by-default unsealed copy
  • Retrieval from a separate node while triggering unsealing on the miner

:shipit:

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be nice (sealer_test.go, should be easy enough to set them up)

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Nit

@magik6k magik6k merged commit 4db8004 into master Apr 29, 2021
@magik6k magik6k deleted the feat/proper-padding branch April 29, 2021 19:14
ribasushi added a commit that referenced this pull request Jul 26, 2021
Fix padding of deals, which only partially shipped in #5988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants