-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to do better padding on pieces being written into sectors #5988
Conversation
Relevant PR's to make this all work:
filecoin-project/go-fil-markets#536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been tested extensively on nerpanet:
- Storage of an 4x artificially padded data filling entire sector
- Storage of a 2x artificially padded data filling half of sector, with the other half being auto-filled by CC
- Retrieval from a separate node from the saved-by-default unsealed copy
- Retrieval from a separate node while triggering unsealing on the miner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests would be nice (sealer_test.go, should be easy enough to set them up)
cbe9bc3
to
44bdf5e
Compare
44bdf5e
to
48feb52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Nit
Fix padding of deals, which only partially shipped in #5988
No description provided.