Actor wrapper codegen #6108
Merged
Actor wrapper codegen #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/actors-codegen
branch
2 times, most recently
from
e17a6c4
to
c988b7a
Compare
arajasek
reviewed
Apr 28, 2021
| Cancel(msig address.Address, txID uint64, hash *ProposalHashData) (*types.Message, error) | ||
| } | ||
|
|
||
| // this type is the same between v0 and v2 |
There was a problem hiding this comment.
Comments such as these are a bit weird to have in the templates
magik6k
force-pushed
the
feat/actors-codegen
branch
2 times, most recently
from
5bcd062
to
1512614
Compare
arajasek
force-pushed
the
feat/actors-codegen
branch
from
01a0bc7
to
85e82ad
Compare
arajasek
reviewed
May 4, 2021
arajasek
approved these changes
May 6, 2021
arajasek
reviewed
May 6, 2021
| - [ ] Generate adapters | ||
| - [ ] Add the new version in `chain/actors/agen/main.go` | ||
| - [ ] Update adapter code in `chain/actors/builtin` if needed | ||
| - [ ] Update `chain/actors/policy/policy.go` |
There was a problem hiding this comment.
note to remove this now that it's generated
There was a problem hiding this comment.
both bulitin and policy are gend
arajasek
suggested changes
May 6, 2021
| decodeTransaction(val *cbg.Deferred) (Transaction, error) | ||
| } | ||
|
|
||
| type Transaction = msig0.Transaction |
| "github.com/ipfs/go-cid" | ||
|
|
||
| msig0 "github.com/filecoin-project/specs-actors/actors/builtin/multisig" | ||
| msig4 "github.com/filecoin-project/specs-actors/v4/actors/builtin/multisig" |
arajasek
force-pushed
the
feat/actors-codegen
branch
from
504098d
to
5f821cc
Compare
arajasek
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
make gen