Move verifreg shed utils to CLI #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Apr 29, 2021
cmd/lotus-shed/verifreg.go
Outdated
Comment on lines
32
to
36
| verifRegVerifyClientCmd, | ||
| verifRegListVerifiersCmd, | ||
| verifRegListClientsCmd, | ||
| verifRegCheckClientCmd, | ||
| verifRegCheckVerifierCmd, |
There was a problem hiding this comment.
This will break existing scripts, maybe we should keep/alias those commands here as hidden/with a deprecated warning?
arajasek
force-pushed
the
asr/verifreg
branch
2 times, most recently
from
ea061b1
to
71848a8
Compare
arajasek
commented
Apr 29, 2021
cmd/lotus-shed/verifreg.go
Outdated
| Name: "verifreg", | ||
| Usage: "Interact with the verified registry actor", | ||
| Flags: []cli.Flag{}, | ||
| Hidden: true, |
There was a problem hiding this comment.
Note this also hides our "use root key to make a verifier" util, but that should be fine...could alternatively hide all the subcommands except that one.
There was a problem hiding this comment.
I'd do this per-command (and print the 'this is depcecated' warnings)
|
run cli docs gen? |
donesies, thanks! |
jennijuju
approved these changes
May 4, 2021
magik6k
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5151 , though v5 actors integration is needed to close it.