fix: use a consistent tipset in commands #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very easy to write an incorrect command that operates over different heads by using the "empty" tipset. This change makes the `LoadTipSet` command helper get the latest head from the lotus daemon if its unset. The cost is an extra call to get the head. That should be trivial in most cases.
Stebalien
commented
Apr 29, 2021
| @@ -723,12 +723,6 @@ var ChainGetCmd = &cli.Command{ | |||
| return err | |||
| } | |||
|
|
|||
| if ts == nil { | |||
There was a problem hiding this comment.
We now always do this.
magik6k
approved these changes
Apr 29, 2021
arajasek
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very easy to write an incorrect command that operates over different heads by using the "empty" tipset. This change makes the
LoadTipSetcommand helper get the latest head from the lotus daemon if its unset.The cost is an extra call to get the head. That should be trivial in most cases.