Generate CLI docs #6145
Merged
Generate CLI docs #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate lotus command lines documents as text and markdown in folder "lotus/documentation/en".
arajasek
approved these changes
Apr 30, 2021
| @@ -368,7 +368,13 @@ docsgen-openrpc-worker: docsgen-openrpc-bin | |||
| .PHONY: docsgen docsgen-md-bin docsgen-openrpc-bin | |||
|
|
|||
| gen: type-gen method-gen docsgen api-gen | |||
| @echo ">>> IF YOU'VE MODIFIED THE CLI, REMEMBER TO ALSO MAKE docsgen-cli" | |||
There was a problem hiding this comment.
Is doscgen-cli slow? Why not just always run it?
There was a problem hiding this comment.
It's not in gen because I'm not sure how to force make to execute one target after another when running in parallel without making one target depend on another - docsgen-cli depends on lotus binaries, which can't build if we're in the middle of generating api code, but we don't want the lotus build to depend on gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2467