Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very basic snapcraft build.
It would be possible to build and package all within snapcraft, however to avoid dealing with snapcraft plugins this would require you to build natively and simply copies the binaries into the snap.
Could be a viable solution for #6030 and to help people get up-and-running more quickly.
When reviewing, keep in mind that the version of hwloc you have installed may not be the same as the version running in, for example, the golang docker container. Ubuntu users running 18.04 have a different version than those running 20.20. This could add a complication during review as native builds may link incorrectly in the snap.
I chose to use
core18
as a base with the knowledge that the golang:1.15.X docker containers have libhwloc1, not libhowloc15, available, and this is frequently the way binaries are built. However, I could be easily convinced to usecore20
and updated libs instead if anyone has this preference.building the snap:
after some time, you are given a snap file you can install.
proof that lotus is contained:
Of course, this snap would then be made available for everyone to use through the snap store, which could be pushed with CI by someone during releases.