Fix randomness fetching around null blocks #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k,
raulk and
whyrusleeping
as code owners
This was referenced May 12, 2021
arajasek
commented
May 12, 2021
| @@ -95,7 +97,12 @@ func (a *ChainAPI) ChainGetRandomnessFromTickets(ctx context.Context, tsk types. | |||
| return nil, xerrors.Errorf("loading tipset key: %w", err) | |||
| } | |||
|
|
|||
| return a.Chain.GetChainRandomness(ctx, pts.Cids(), personalization, randEpoch, entropy) | |||
| // Doing this here is slightly nicer than doing it in the chainstore directly, but it's still bad for ChainAPI to reason about network upgrades | |||
| if randEpoch > build.UpgradeHyperdriveHeight { | |||
There was a problem hiding this comment.
Would love a creative suggestion that allows us to not do this
|
This version seems better to me. The Chain API having to check network version is annoying, especially if we consider that in future upgrades might depend on state and not a pure chain. |
arajasek
force-pushed
the
asr/not-hack-drand
branch
from
b443c2f
to
21b4741
Compare
|
Added a test which will pass once we make a minor tweak to the tipset skipcache index (waiting on some input from Why) |
magik6k
reviewed
May 27, 2021
| @@ -833,3 +891,55 @@ func TestSyncCheckpointEarlierThanHead(t *testing.T) { | |||
| require.Equal(tu.t, p1Head, a.TipSet()) | |||
| tu.assertBad(p1, b.TipSet()) | |||
| } | |||
|
|
|||
| func TestDrandNull(t *testing.T) { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, because of the tipset cache thing i mentioned above^
Kubuxu
approved these changes
May 27, 2021
arajasek
commented
May 27, 2021
arajasek
force-pushed
the
asr/not-hack-drand
branch
from
9da93a6
to
10b9313
Compare
magik6k
approved these changes
May 28, 2021
|
|
||
| require.Equal(t, []byte(rand), expectedRand) | ||
| build.UpgradeHyperdriveHeight = ov5h | ||
|
|
There was a problem hiding this comment.
Would it be easy enough to test that a second node can sync to this chain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the larger but "better" fix to the critical portion of #3613.