gateway: spin off from cmd to package #6294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the gateway implementation to the `gateway` top-level package. cmd/lotus-gateway now contains only the entrypoint. This separation is important for the testing refactors.
dirkmc
reviewed
May 19, 2021
raulk
force-pushed
the
raulk/refactor-gateway
branch
from
625b187
to
ac4f3ab
Compare
dirkmc
approved these changes
May 19, 2021
magik6k
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the gateway implementation to the
gatewaytop-level package.cmd/lotus-gatewaynow contains only the binary entrypoint.This separation is important for the testing refactors that are WIP, where all end-to-end integration tests that are scattered across the codebase are being consolidated in an
itestpackage.