Add a command to list retrievals #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
added
area/api
impact/api-breakage
|
@hannahhoward is this an API that you want to be available for most users? If so, i thinkk it should be added to the v0 api package as v0 will still be the default for several months! |
Currently, there is no way to inspect retrievals on a client. This adds said command, allow with corresponding APIs
hannahhoward
force-pushed
the
feat/list-retrievals
branch
from
1e7181d
to
9e73e43
Compare
|
I'd suggest we show deals that errored out by default (with a flag to hide). It seems that people often get confused that their failed deal doesn't show up in list-deals, list-transfers etc. eg see #6346 |
|
updated to have show-failed as default true |
dirkmc
approved these changes
Jun 4, 2021
magik6k
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Especially in automated environments with lots of concurrent retrievals (see dealbot), the lack of a command monitor all retrievals becomes a pain point. My recollection is we didn't build this original cause we assumed "well retrievals will be fast so you wont want to monitor them" -- but this isn't neccesarily true -- large retrievals on slow connections can take a while, especially if you're running lots in parallel
Implementation
-- v1API (assuming I should add here cause it's a new, untested API) --
-- Add ClientListRetrievals
-- Add ClientGetRetrievalUpdates
-- cli
-- add
lotus client list-retrievals-- based onlotus client list-dealsandlotus client list-transfersDo we have a way we are testing commands right now (other than by hand)? If not I will run against some lotus nodes I am working with.