Network version 13 (v1.11) #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce v5 actors
FIP 0013 addenda
FIP 13 addenda: correctly handle commit batch timer
…atcher Fix tests
Fix nv13 1.11 tests
arajasek
approved these changes
Jun 2, 2021
mvdan
added a commit
to filecoin-project/dealbot
that referenced
this pull request
Jun 7, 2021
Since the network version 13 merge in Lotus master on June 3rd, at filecoin-project/lotus#6342, our integration tests would seem to hang at StorageDealAwaitingPreCommit for long enough to make the tests time out. After some debugging and interaction with Łukasz, it turns out that BatchPreCommits is a new option that's on by default, which made our single deal wait for more sectors to go through. After fixing that, we had the same problem with StorageDealSealing, which is similarly fixed by turning off AggregateCommits. Lotus doesn't have a way to set or modify these options directly, so our next best option is a bit of sed to modify the TOML.
willscott
pushed a commit
to filecoin-project/dealbot
that referenced
this pull request
Jun 7, 2021
Since the network version 13 merge in Lotus master on June 3rd, at filecoin-project/lotus#6342, our integration tests would seem to hang at StorageDealAwaitingPreCommit for long enough to make the tests time out. After some debugging and interaction with Łukasz, it turns out that BatchPreCommits is a new option that's on by default, which made our single deal wait for more sectors to go through. After fixing that, we had the same problem with StorageDealSealing, which is similarly fixed by turning off AggregateCommits. Lotus doesn't have a way to set or modify these options directly, so our next best option is a bit of sed to modify the TOML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6340, but with master merged in, and conflicts resolved