Fund miners with the aggregate fee when ProveCommitting #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Jun 9, 2021
| return []sealiface.CommitBatchRes{res}, xerrors.Errorf("couldn't get base fee: %w", err) | ||
| } | ||
|
|
||
| aggFee := miner5.AggregateNetworkFee(len(infos), bf) |
There was a problem hiding this comment.
This should be added to the actor policy wrappers and abstracted, but I was lazy...Can do so if people want it.
There was a problem hiding this comment.
I'd just do it. Otherwise, we'll miss it if it changes (and this is something I can definitely see changing.
Stebalien
reviewed
Jun 9, 2021
| return []sealiface.CommitBatchRes{res}, xerrors.Errorf("couldn't get base fee: %w", err) | ||
| } | ||
|
|
||
| aggFee := miner5.AggregateNetworkFee(len(infos), bf) |
There was a problem hiding this comment.
I'd just do it. Otherwise, we'll miss it if it changes (and this is something I can definitely see changing.
|
|
||
| aggFee := miner5.AggregateNetworkFee(len(infos), bf) | ||
|
|
||
| goodFunds := big.Add(b.feeCfg.MaxCommitGasFee, big.Add(collateral, aggFee)) |
There was a problem hiding this comment.
Hm.... shouldn't we have a new field for this? Or shouldn't the max fee be a function of the number of sectors, or something like that?
arajasek
force-pushed
the
asr/aggregate-fee
branch
from
9a6f48a
to
b0c9dd4
Compare
|
Depends on #6416 now |
magik6k
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.