Appimage v1.10.0 rc3 #6492
Merged
Appimage v1.10.0 rc3 #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @coryschwartz! however, it has conflict and lint is unhappy |
coryschwartz
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
This should only be merged to v1.10, not master, that's why there were conflicts. I changed the base to resolve the conflicts. Looks like the linter used up too much memory! |
jennijuju
approved these changes
Jun 15, 2021
added 3 commits
June 17, 2021 23:48
|
Edited so go-rice only uses go-embed mode when building the appimage. Just a reminder, that this is implemented differently on master. On master, the embeds use the embed feature of go 1.16. |
ognots
approved these changes
Jun 18, 2021
arajasek
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This back-ports the appimage build to v1.10.0
Same AppImageBuilder.yaml as what is found on the master branch. The difference is the way static file embeds work.
On the master branch we ended up swapping to go 1.16 to use static file embeds. v1.10.0 doesn't have go 1.16 yet, so I'm using go rice embed.
This comment states the problem: #6208 (comment)
There will be a massive go file generated for the embedded files. You can get rid of it using
make clean. In the future this isn't a problem; hopefully it isn't too much of an issue for people on this branch.a circleci test run without the version and tag filter is here. Looks like it builds successfully.
https://app.circleci.com/pipelines/github/filecoin-project/lotus/15011/workflows/62210486-95f4-48ff-a0ab-92b65d1c4b52/jobs/172819