Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep retrieval for selectors: no functional changes #7306

Merged

Conversation

ribasushi
Copy link
Collaborator

No description provided.

@ribasushi ribasushi force-pushed the chore/prep-retrieval-for-selectors_no-func-changes branch from 2a162da to c679899 Compare September 9, 2021 10:40
Slight import-name shuffle, no functional changes
@ribasushi ribasushi force-pushed the chore/prep-retrieval-for-selectors_no-func-changes branch from c679899 to 2c5f438 Compare September 9, 2021 10:46
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #7306 (2c5f438) into master (92c12f9) will increase coverage by 0.02%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7306      +/-   ##
==========================================
+ Coverage   39.15%   39.17%   +0.02%     
==========================================
  Files         614      614              
  Lines       64984    64989       +5     
==========================================
+ Hits        25443    25462      +19     
+ Misses      35135    35120      -15     
- Partials     4406     4407       +1     
Impacted Files Coverage Δ
node/impl/client/client.go 40.46% <38.88%> (-0.15%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
extern/sector-storage/worker_tracked.go 90.14% <0.00%> (-4.23%) ⬇️
chain/gen/gen.go 66.06% <0.00%> (-1.22%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
markets/storageadapter/dealpublisher.go 80.97% <0.00%> (-0.49%) ⬇️
node/impl/full/chain.go 14.73% <0.00%> (+0.57%) ⬆️
miner/miner.go 55.96% <0.00%> (+0.66%) ⬆️
chain/store/store.go 65.07% <0.00%> (+0.70%) ⬆️
chain/vm/vm.go 60.59% <0.00%> (+1.11%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c12f9...2c5f438. Read the comment docs.

@ribasushi ribasushi marked this pull request as ready for review September 9, 2021 10:56
@ribasushi ribasushi requested a review from a team as a code owner September 9, 2021 10:56
@ribasushi
Copy link
Collaborator Author

All of this is cosmetic changes only, switching bulk of car-retrieval to SelectiveCar. codecov will bounce back in another branch.

@jennijuju jennijuju merged commit 1ce7c25 into master Sep 9, 2021
@jennijuju jennijuju deleted the chore/prep-retrieval-for-selectors_no-func-changes branch September 9, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants