Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable appimage #7707

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Disable appimage #7707

merged 1 commit into from
Dec 2, 2021

Conversation

travisperson
Copy link
Contributor

@travisperson travisperson commented Nov 29, 2021

It appears recently something has changed in circleci and we no longer have access to the /dev/snd device which is causing the appimage tests to fail during setup.

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should modify template.yml, so that the gen-check doesn't complain.

@travisperson travisperson changed the title Patch appimagetool to run in docker Disable appimage Dec 1, 2021
appimage testing is currently broken due to a requirement to have access
to /dev/snd, which is not present on the image we are using in circleci.
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #7707 (66c8c66) into master (0cfc344) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7707      +/-   ##
==========================================
- Coverage   39.59%   39.54%   -0.06%     
==========================================
  Files         640      640              
  Lines       68326    68326              
==========================================
- Hits        27056    27018      -38     
- Misses      36631    36655      +24     
- Partials     4639     4653      +14     
Impacted Files Coverage Δ
extern/sector-storage/worker_tracked.go 76.53% <0.00%> (-8.17%) ⬇️
chain/rand/rand.go 57.89% <0.00%> (-6.32%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
chain/types/blockheader.go 55.55% <0.00%> (-2.23%) ⬇️
extern/sector-storage/sched_worker.go 78.48% <0.00%> (-1.17%) ⬇️
miner/miner.go 56.95% <0.00%> (-0.67%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-0.43%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfc344...66c8c66. Read the comment docs.

@magik6k magik6k merged commit 9331714 into master Dec 2, 2021
@magik6k magik6k deleted the fix/app-image-build branch December 2, 2021 13:39
@jennijuju jennijuju mentioned this pull request Dec 8, 2021
2 tasks
coryschwartz pushed a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants