-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable appimage #7707
Disable appimage #7707
Conversation
300212c
to
da0c7ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should modify template.yml
, so that the gen-check doesn't complain.
da0c7ba
to
4f9afa8
Compare
appimage testing is currently broken due to a requirement to have access to /dev/snd, which is not present on the image we are using in circleci.
4f9afa8
to
66c8c66
Compare
Codecov Report
@@ Coverage Diff @@
## master #7707 +/- ##
==========================================
- Coverage 39.59% 39.54% -0.06%
==========================================
Files 640 640
Lines 68326 68326
==========================================
- Hits 27056 27018 -38
- Misses 36631 36655 +24
- Partials 4639 4653 +14
Continue to review full report at Codecov.
|
This reverts commit 6b08680.
It appears recently something has changed in circleci and we no longer have access to the /dev/snd device which is causing the appimage tests to fail during setup.