storageminer: Setup actor on init #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/storminer-init
branch
from
ae04dbf
to
8a8c3de
Compare
|
The no such actor is probably because youre trying to send the createMiner message from an actor that has no funds (aka, doesnt exist yet). We probably need part of the flow to wait for the account it created to receive money. So we can create the new key, then say "send at least X FIL to this address". then once we see the account has funds, move on. I'm all ears if you have better ideas about making that nicer |
magik6k
force-pushed
the
feat/storminer-init
branch
from
8a8c3de
to
2c3ca43
Compare
magik6k
force-pushed
the
feat/storminer-init
branch
from
2c3ca43
to
a825b3b
Compare
|
Did some more digging, it looks like the StorageMarket actor isn't, and then The error comes from https://github.com/filecoin-project/go-lotus/blob/master/chain/vm/mkactor.go#L37 I guess we should probably be setting the state up in genesis block? |
| return err | ||
| } | ||
|
|
||
| k, err := wallet.GenerateKey(types.KTSecp256k1) // TODO: review: is this right? |
There was a problem hiding this comment.
Yep, this works, though we will want to use BLS keys everywhere we can
whyrusleeping
approved these changes
Jul 26, 2019
dumikau
pushed a commit
to protofire/lotus
that referenced
this pull request
Jun 8, 2023
* fix actor state inspection and serialization * checkpoint acessors and new ipc bundle * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how correct this is, but it's an attempt to move something on this front
Also, miming now fails with: