-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional test annotations #8272
Conversation
solve conflict
solve merge conflict
Refresh master
Codecov Report
@@ Coverage Diff @@
## master #8272 +/- ##
==========================================
+ Coverage 40.16% 40.29% +0.12%
==========================================
Files 679 679
Lines 73992 73992
==========================================
+ Hits 29719 29815 +96
+ Misses 39093 38952 -141
- Partials 5180 5225 +45
|
@brdji @TheDivic can you add more details about what needs to be merged, and can we see and link of the missing info on your dashboard? |
@BlocksOnAChain As you can see most of the systems/subsystems are "gray" and have a bad score. That's because a large part of test annotations is not merged into lotus master, and the test crawler (run through CI) is extracting annotation from lotus master and can't find them. Thus, the STM shows those behaviors as untested. |
As @TheDivic said, these annotations cannot currently be seen in the STM because the test crawler ignores these files - thus the tests are ignored and the behavior is marked as untested. This PR would annotate all of the remaining test files and tests, and they would show up correctly in the STM catalog, marking the corresponding behaviors as tested (depending on the test type - most of the tests in this PR are unit tests). |
Proposed Changes
Add missing test annotations from the Bloxico lotus fork.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps