Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sealing: More SnapDeals config knobs #8343

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 17, 2022

Proposed Changes

This PR adds 2 new config fields which should make a few more usecases for SnapDeals much easier to use.

  # Prefer creating new sectors even if there are sectors Available for upgrading.
  # This setting combined with MaxUpgradingSectors set to a value higher than MaxSealingSectorsForDeals makes it
  # possible to use fast sector upgrades to handle high volumes of storage deals, while still using the simple sealing
  # flow when the volume of storage deals is lower.
  #
  # type: bool
  # env var: LOTUS_SEALING_PREFERNEWSECTORSFORDEALS
  PreferNewSectorsForDeals = false

  # Upper bound on how many sectors can be sealing+upgrading at the same time when upgrading CC sectors with deals (0 = MaxSealingSectorsForDeals)
  #
  # type: uint64
  # env var: LOTUS_SEALING_MAXUPGRADINGSECTORS
  MaxUpgradingSectors = 0

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 17, 2022 20:27
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #8343 (e1a06b3) into master (d118ef9) will increase coverage by 7.86%.
The diff coverage is 81.25%.

❗ Current head e1a06b3 differs from pull request most recent head e767981. Consider uploading reports for the commit e767981 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8343      +/-   ##
==========================================
+ Coverage   32.35%   40.21%   +7.86%     
==========================================
  Files         678      682       +4     
  Lines       74251    74459     +208     
==========================================
+ Hits        24027    29947    +5920     
+ Misses      45635    39272    -6363     
- Partials     4589     5240     +651     
Impacted Files Coverage Δ
extern/sector-storage/piece_provider.go 54.83% <ø> (-0.49%) ⬇️
extern/storage-sealing/input.go 56.33% <71.42%> (+15.07%) ⬆️
itests/kit/node_full.go 95.12% <100.00%> (+1.37%) ⬆️
itests/kit/node_miner.go 81.01% <100.00%> (ø)
itests/kit/node_opts.go 71.66% <100.00%> (+19.74%) ⬆️
node/modules/storageminer.go 64.03% <100.00%> (+8.41%) ⬆️
node/modules/storageminer_dagstore.go 61.53% <0.00%> (-8.47%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
cli/util/api.go 24.27% <0.00%> (-2.52%) ⬇️
node/builder.go 76.69% <0.00%> (-0.45%) ⬇️
... and 212 more

@magik6k magik6k merged commit 7c4d3a4 into master Mar 25, 2022
@magik6k magik6k deleted the feat/more-snap-config branch March 25, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants