Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner cli: proving check --faulty, faults in storage list sectors #8349

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 19, 2022

Proposed Changes

  • Print faults in lotus-miner storage list sectors so it's easy to spot where the faulty sectors are
  • Add a --faulty flag to lotus-miner proving check, so that it only checks faulty sectors, which is much, much faster

Additional Info

2022-03-19-124513_1288x323_scrot

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 19, 2022 11:56
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@magik6k magik6k merged commit d437f19 into master Mar 25, 2022
@magik6k magik6k deleted the feat/faulty-cli-utils branch March 25, 2022 19:29
@RobQuistNL
Copy link
Contributor

It doesn't seem to work;

$ lotus-miner proving check --faulty 28
ERROR: rg is nil

@beck-8
Copy link
Contributor

beck-8 commented May 3, 2022

It doesn't seem to work;

$ lotus-miner proving check --faulty 28
ERROR: rg is nil

28 is deadlines number , you may be is sectors number

@RobQuistNL
Copy link
Contributor

no, I was trying to check deadline 28 not sector 28

@beck-8
Copy link
Contributor

beck-8 commented May 3, 2022

no, I was trying to check deadline 28 not sector 28

oh,Confirm that this deadline has sectors, and look at the code to know the reason

@RobQuistNL
Copy link
Contributor

The issue here is the following; #8560

@RobQuistNL
Copy link
Contributor

and it has 2349 sectors :) (all of which were faulty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants