Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: always do cooldown in handleSubmitReplicaUpdateFailed #8353

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 21, 2022

handleSubmitReplicaUpdateFailed seems to have a bunch of paths which can lead us to retry in a loop wasting a ton of resources. Adding a cooldown to it at least makes sure we don't kill the miner node when we enter one of those fail loops.

@magik6k magik6k requested a review from a team as a code owner March 21, 2022 09:34
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #8353 (5884385) into master (a94e47c) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8353      +/-   ##
==========================================
- Coverage   40.23%   40.22%   -0.02%     
==========================================
  Files         682      682              
  Lines       74428    74428              
==========================================
- Hits        29946    29935      -11     
- Misses      39247    39255       +8     
- Partials     5235     5238       +3     
Impacted Files Coverage Δ
extern/storage-sealing/states_failed.go 0.00% <0.00%> (ø)
extern/storage-sealing/input.go 55.55% <100.00%> (+0.21%) ⬆️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
chain/vm/mkactor.go 48.48% <0.00%> (-3.04%) ⬇️
extern/storage-sealing/currentdealinfo.go 72.97% <0.00%> (-1.81%) ⬇️
miner/miner.go 56.39% <0.00%> (-1.64%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
chain/messagepool/selection.go 83.52% <0.00%> (-0.78%) ⬇️
chain/sync_manager.go 73.91% <0.00%> (-0.63%) ⬇️
... and 11 more

@magik6k magik6k merged commit 1a0fc75 into master Mar 21, 2022
@magik6k magik6k deleted the fix/ru-retry-loop branch March 21, 2022 15:38
jennijuju added a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants