Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: --max-piece-size in set-ask is no longer required #8361

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Mar 23, 2022

Related Issues

Closes issue #7963

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner March 23, 2022 02:06
@geoff-vball geoff-vball requested review from arajasek and removed request for a team March 23, 2022 02:06
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #8361 (5ba4a78) into master (1609317) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8361      +/-   ##
==========================================
- Coverage   40.26%   40.24%   -0.03%     
==========================================
  Files         683      683              
  Lines       74479    74479              
==========================================
- Hits        29988    29972      -16     
- Misses      39264    39277      +13     
- Partials     5227     5230       +3     
Impacted Files Coverage Δ
cmd/lotus-miner/market.go 22.17% <ø> (ø)
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-9.81%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 69.18% <0.00%> (-3.25%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
itests/kit/blockminer.go 69.56% <0.00%> (-1.09%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
storage/wdpost_run.go 69.91% <0.00%> (-0.61%) ⬇️
chain/consensus/filcns/filecoin.go 52.17% <0.00%> (-0.44%) ⬇️
... and 13 more

@magik6k magik6k merged commit dbc6b32 into master Mar 23, 2022
@magik6k magik6k deleted the gstuart/set-ask-optional-params branch March 23, 2022 15:08
@magik6k magik6k changed the title --max-piece-size in set-ask is no longer required fix: cli: --max-piece-size in set-ask is no longer required Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants