Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: worker: check fd limit on startup #8390

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 28, 2022

Related Issues

Closes #8387

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 28, 2022 22:08
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #8390 (5a42083) into master (a709a0a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8390      +/-   ##
==========================================
- Coverage   40.67%   40.58%   -0.09%     
==========================================
  Files         686      686              
  Lines       75262    75270       +8     
==========================================
- Hits        30613    30551      -62     
- Misses      39363    39412      +49     
- Partials     5286     5307      +21     
Impacted Files Coverage Δ
cmd/lotus-worker/main.go 0.00% <0.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-8.48%) ⬇️
blockstore/api.go 24.00% <0.00%> (-8.00%) ⬇️
chain/stmgr/call.go 65.94% <0.00%> (-6.49%) ⬇️
storage/wdpost_sched.go 81.37% <0.00%> (-5.89%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-4.40%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-3.61%) ⬇️
chain/events/state/predicates.go 53.09% <0.00%> (-2.07%) ⬇️
chain/actors/builtin/market/v7.go 45.16% <0.00%> (-1.62%) ⬇️
... and 13 more

@magik6k magik6k merged commit 064c3d4 into master Mar 28, 2022
@magik6k magik6k deleted the feat/worker-ulimitn-check branch March 28, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker: Refuse to start with low FD limits
2 participants