Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: Added error checking #8404

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

simlecode
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@simlecode simlecode requested a review from a team as a code owner March 30, 2022 02:30
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #8404 (f094403) into master (7eb7edb) will increase coverage by 0.48%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8404      +/-   ##
==========================================
+ Coverage   40.12%   40.60%   +0.48%     
==========================================
  Files         686      686              
  Lines       75381    75383       +2     
==========================================
+ Hits        30248    30612     +364     
+ Misses      39871    39455     -416     
- Partials     5262     5316      +54     
Impacted Files Coverage Δ
extern/sector-storage/manager.go 62.78% <0.00%> (+1.01%) ⬆️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
chain/vm/syscalls.go 37.74% <0.00%> (-1.33%) ⬇️
extern/sector-storage/sched_worker.go 79.41% <0.00%> (-1.18%) ⬇️
itests/kit/blockminer.go 69.56% <0.00%> (-1.09%) ⬇️
chain/vm/vm.go 61.63% <0.00%> (-1.07%) ⬇️
paychmgr/simple.go 82.42% <0.00%> (-0.75%) ⬇️
extern/storage-sealing/fsm.go 60.33% <0.00%> (-0.67%) ⬇️
... and 31 more

@magik6k
Copy link
Contributor

magik6k commented Mar 30, 2022

Thanks for the PR!

@magik6k magik6k merged commit 39c38c4 into filecoin-project:master Mar 30, 2022
@simlecode simlecode deleted the fix/not_check_error branch March 31, 2022 00:57
@silvianetobessa
Copy link

Hello @simlecode !

This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here).

Please reach out to us through commons@protocol.ai to receive the instructions on how to claim your reward!

@simlecode
Copy link
Contributor Author

@silvianetobessa I'm really sorry for the late reply. You can contact me through my email hj1557986@gmail.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants