-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor: actor bundling system #8838
Merged
Merged
Commits on Jun 10, 2022
-
feat: build: refactor actor bundling system
1. Include the builtin-actors in the lotus source tree. 2. Embed the bundle on build instead of downloading at runtime. 3. Avoid reading the bundle whenever possible by including bundle metadata (the bundle CID, the actor CIDs, etc.). 4. Remove everything related to dependency injection. 1. We're no longer downloading the bundle, so doing anything ahead of time doesn't really help. 2. We register the manifests on init because, unfortunately, they're global. 3. We explicitly load the current actors bundle in the genesis state-tree method. 4. For testing, we just change the in-use bundle with a bit of a hack. It's not great, but using dependency injection doesn't make any sense either because, again, the manifest information is global. fixes #8701
Configuration menu - View commit details
-
Copy full SHA for eff32b7 - Browse repository at this point
Copy the full SHA eff32b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb35ad6 - Browse repository at this point
Copy the full SHA fb35ad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f4c33c - Browse repository at this point
Copy the full SHA 2f4c33cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2c7407 - Browse repository at this point
Copy the full SHA e2c7407View commit details -
feat: build: remove the bundle.toml file
Instead, we override bundles using environment variables and overrides in the build parameter files.
Configuration menu - View commit details
-
Copy full SHA for 54a4097 - Browse repository at this point
Copy the full SHA 54a4097View commit details
Commits on Jun 11, 2022
-
fix: tests: correctly use mockProofs/InsecurePoStValidation
1. Use mockProofs to determine the correct test bundle. 2. Don't even bother setting InsecurePoStValidation for itests, it's already set.
Configuration menu - View commit details
-
Copy full SHA for ea07648 - Browse repository at this point
Copy the full SHA ea07648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33979ee - Browse repository at this point
Copy the full SHA 33979eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec9dd5c - Browse repository at this point
Copy the full SHA ec9dd5cView commit details -
feat: verify that bundles have all actors when we read the metadata
This gets tested: 1. When we load dynamically (by path) specified bundles. 2. When we decode the embedded bundles to generate the metadata. Effectively, this lets us test that the embedded bundles are actually correct.
Configuration menu - View commit details
-
Copy full SHA for f01bd41 - Browse repository at this point
Copy the full SHA f01bd41View commit details
Commits on Jun 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fff677d - Browse repository at this point
Copy the full SHA fff677dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.