Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cli: Break out of retrieval if provider cancels #8912

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jun 23, 2022

Related Issues

Proposed Changes

Miner can send a Cancelled message if they are unable to unseal data. There is currently no return value for this case, so the client will hang. Client will now exit if they receive a Cancelled message.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner June 23, 2022 21:00
@RobQuistNL
Copy link
Contributor

How do I actually cancel a retrieval as a storage provider?

@geoff-vball
Copy link
Contributor Author

@RobQuistNL I don't think we have any ways to cancel manually.

The one situation I was testing was if the SP agrees to the deal and has a sealed copy of the data, but is unable to unseal the data for some reason, the deal will automatically be cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants