clean up ethtypes: rationalize ethtypes.EthAddressFromFilecoinAddress and conversion methods #9992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidate both functions. - Make decodeHexString check for equality length.
raulk
force-pushed
the
raulk/ethtypes-cleanup
branch
from
6d0c4d2
to
7871605
Compare
raulk
force-pushed
the
raulk/ethtypes-cleanup
branch
from
7871605
to
8e6bead
Compare
arajasek
approved these changes
Jan 12, 2023
| s = "0" + s | ||
| } | ||
| if len(s) != expectedLen*2 { | ||
| return []byte{}, xerrors.Errorf("expected length %d, got %d", expectedLen, len(s)) |
There was a problem hiding this comment.
Is returning nil not more canonical here?
There was a problem hiding this comment.
Yep, can do. I'm working on another fix that affects this code, so will do in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Clean up ethtypes; see commit log.
Proposed Changes
See commit log.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps