This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Support streaming and raw i/o in contribution #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
changed the title
Closed
porcuquine
force-pushed
the
feat/stream-raw
branch
from
d0214e9 to
0846b1f
Compare
porcuquine
force-pushed
the
feat/stream-raw
branch
3 times, most recently
from
b3fba3f to
0cd487f
Compare
| } | ||
|
|
||
| this_chunk_size = usize::min(chunk_size, chunks_to_read - chunks_read); | ||
| h_chunk.truncate(0); |
There was a problem hiding this comment.
These are good uses of truncate.
| } | ||
| } | ||
|
|
||
| fn dump_g1<W: Write>(mut writer: W, g1: &G1Affine, raw: bool) -> io::Result<usize> { |
DrPeterVanNostrand
approved these changes
Jun 28, 2020
porcuquine
force-pushed
the
feat/stream-raw
branch
from
0cd487f to
21d2252
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #8 and includes support for raw i/o.
This branch is currently used by filecoin-project/rust-fil-proofs#1188. Once this merges, and the changes are released, that PR can be finalized.