Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batched JSON-RPC requests in Lotus #1047

Closed
raulk opened this issue Nov 3, 2022 · 4 comments
Closed

Support batched JSON-RPC requests in Lotus #1047

raulk opened this issue Nov 3, 2022 · 4 comments

Comments

@raulk
Copy link
Member

raulk commented Nov 3, 2022

Context

Batched requests are an optional feature in the JSON-RPC 2.0 specification. However, Ethereum clients offer this feature and downstream users like block explorers (e.g. Blockscout) depend on it.

In the past, the Lotus team rejected this feature and redirected users to using the WebSockets endpoint, on the grounds that it would have similar network properties. However, the desire to have Ethereum applications interact seamlessly with Lotus brings about an added motivation to build this feature.

Proposed plan

  1. Implement batching in go-jsonrpc with sequential processing of individual requests.
  2. If necessary, in the near future we can optimise by adding a worker pool for fork-join concurrency.
@raulk raulk self-assigned this Nov 3, 2022
@raulk raulk added this to the M2.1 milestone Nov 3, 2022
@raulk raulk mentioned this issue Nov 3, 2022
85 tasks
@Stebalien Stebalien modified the milestones: M2.1, M2.1 Post code-freeze Nov 8, 2022
@Stebalien Stebalien added the P2 P2: Should be resolved label Nov 8, 2022
@alvin-reyes
Copy link

Hi @Stebalien, @raulk

I was trying to hook the wallaby testnet on to my local blockscout and its seems to fail due to the lack of support for batch json-rpc requests. I'd be interested to know when can we have this so I can deploy a blockscout instance for FEVM.

@maciejwitowski
Copy link
Contributor

maciejwitowski commented Jan 16, 2023

I'm considering assigning it to @geoff-vball for this week.
What do you think @geoff-vball @jennijuju @raulk?

@maciejwitowski
Copy link
Contributor

Discussed on slack to deprioritise it for now.

@Stebalien
Copy link
Member

This has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants