introduce a crypto::recover_secp_public_key syscall. #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: karim <karim.dev@gmail.com>
raulk
commented
Aug 12, 2022
fvm/src/call_manager/default.rs
Outdated
Comment on lines
354
to
362
| // prepare actor code | ||
| // TODO remove once the EVM smart contract actor is integrated in the builtin-actors bundle | ||
| // https://github.com/filecoin-project/ref-fvm/issues/693 | ||
| self.engine() | ||
| .load_code_cid(&state.code, self.blockstore()) | ||
| .map_err( | ||
| |_| syscall_error!(NotFound; "actor code cid does not exist {}", &state.code), | ||
| )?; | ||
|
|
There was a problem hiding this comment.
Isn't this part of a separate patch?
- Introduce a secp recover syscall.
- Code loading?
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 50.92% 50.66% -0.26%
==========================================
Files 120 120
Lines 9691 9742 +51
==========================================
+ Hits 4935 4936 +1
- Misses 4756 4806 +50
|
Stebalien
approved these changes
Aug 12, 2022
fvm/src/machine/engine.rs
Outdated
Comment on lines
211
to
216
| /// Attempts to load Actor Code CID from the blockstore and | ||
| /// instantiate a wasmtime Module from the WASM bytecode if the | ||
| /// given code CID is present, otherwise returns None. | ||
| /// | ||
| /// Implicitly caches instantiated modules. | ||
| pub fn load_code_cid<BS: Blockstore>( |
There was a problem hiding this comment.
install_code? We don't actually need to return it.
There was a problem hiding this comment.
SGTM. I'll move this part to a different patch and we can address there.
mriise
approved these changes
Aug 13, 2022
|
The extra feature has been moved to #711 and this PR is now strictly about the recover_secp_public_key syscall. |
This was referenced Aug 14, 2022
Stebalien
pushed a commit
that referenced
this pull request
Aug 29, 2022
Co-authored-by: karim <karim.dev@gmail.com>
shamb0
pushed a commit
to shamb0/ref-fvm
that referenced
this pull request
Sep 23, 2022
…t#707) Co-authored-by: karim <karim.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #627 with a clean diff, refresh from master, and some small changes (check commit log).