feat: update rust-toolchain to 1.62.0 (#1623)

* feat: update rust-toolchain to 1.62.0

* Bump toolchain to 1.62.1

Use the most recent stable release.

Co-authored-by: Volker Mische <volker.mische@gmail.com>

fil-proofs-param/src/bin/parampublish.rs

@@ -70,7 +70,7 @@ fn is_well_formed_filename(filename: &str) -> bool {
         return false;
     }
     let version_is_valid =
-        version.get(0..1).unwrap() == "v" && version[1..].chars().all(|c| c.is_digit(10));
+        version.get(0..1).unwrap() == "v" && version[1..].chars().all(|c| c.is_ascii_digit());
     if !version_is_valid {
         warn!(
             "filename does not start with version: {}, ignoring file",

fil-proofs-param/src/bin/srspublish.rs

@@ -42,7 +42,7 @@ fn is_well_formed_filename(filename: &str) -> bool {
         return false;
     }
     let version_is_valid =
-        version.get(0..1).unwrap() == "v" && version[1..].chars().all(|c| c.is_digit(10));
+        version.get(0..1).unwrap() == "v" && version[1..].chars().all(|c| c.is_ascii_digit());
     if !version_is_valid {
         warn!(
             "filename does not start with version: {}, ignoring file",

fil-proofs-tooling/src/bin/micro.rs

@@ -224,23 +224,23 @@ fn parse_criterion_out(s: impl AsRef<str>) -> Vec<CriterionResult> {
 
 /// parses a string of the form "521.80 KiB/s".
 fn throughput_to_uom(s: &str) -> String {
-    let parts = s.trim().split_whitespace().collect::<Vec<_>>();
+    let parts = s.split_whitespace().collect::<Vec<_>>();
     assert_eq!(parts.len(), 2, "invalid val: {:?}", parts);
     let _: f64 = parts[0].parse().expect("invalid number");
     parts[1].to_string()
 }
 
 /// parses a string of the form "521.80 KiB/s".
 fn throughput_val(s: &str) -> f64 {
-    let parts = s.trim().split_whitespace().collect::<Vec<_>>();
+    let parts = s.split_whitespace().collect::<Vec<_>>();
     assert_eq!(parts.len(), 2, "invalid val: {:?}", parts);
     let ts: f64 = parts[0].parse().expect("invalid number");
     ts
 }
 
 /// parses a string of the form "123.12 us".
 fn time_to_us(s: &str) -> f64 {
-    let parts = s.trim().split_whitespace().collect::<Vec<_>>();
+    let parts = s.split_whitespace().collect::<Vec<_>>();
     assert_eq!(parts.len(), 2, "invalid val: {:?}", parts);
     let ts: f64 = parts[0].parse().expect("invalid number");
     let normalized = match parts[1] {

filecoin-hashers/src/sha256.rs

@@ -223,8 +223,8 @@ impl HashFunction<Sha256Domain> for Sha256Function {
         let le_bits = be_bits
             .chunks(8)
             .flat_map(|chunk| chunk.iter().rev())
-            .cloned()
             .take(Fr::CAPACITY as usize)
+            .cloned()
             .collect::<Vec<_>>();
         multipack::pack_bits(cs.namespace(|| "pack_le"), &le_bits)
     }

rust-toolchain

@@ -1 +1 @@
-1.59.0
+1.62.1

storage-proofs-core/src/gadgets/por.rs

@@ -336,7 +336,7 @@ impl<'a, Tree: 'static + MerkleTreeTrait> CompoundProof<'a, PoR<Tree>, PoRCircui
     }
 }
 
-impl<'a, Tree: MerkleTreeTrait> Circuit<Fr> for PoRCircuit<Tree> {
+impl<Tree: MerkleTreeTrait> Circuit<Fr> for PoRCircuit<Tree> {
     /// # Public Inputs
     ///
     /// This circuit expects the following public inputs.
@@ -418,7 +418,7 @@ impl<'a, Tree: MerkleTreeTrait> Circuit<Fr> for PoRCircuit<Tree> {
     }
 }
 
-impl<'a, Tree: MerkleTreeTrait> PoRCircuit<Tree> {
+impl<Tree: MerkleTreeTrait> PoRCircuit<Tree> {
     pub fn new(proof: Tree::Proof, private: bool) -> Self {
         PoRCircuit::<Tree> {
             value: Root::Val(Some(proof.leaf().into())),

storage-proofs-porep/src/stacked/vanilla/graph.rs

@@ -331,7 +331,7 @@ where
     }
 }
 
-impl<'a, H, G> StackedGraph<H, G>
+impl<H, G> StackedGraph<H, G>
 where
     H: Hasher,
     G: Graph<H> + ParameterSetMetadata + Sync + Send,

storage-proofs-porep/src/stacked/vanilla/porep.rs

@@ -16,7 +16,7 @@ use crate::{
     PoRep,
 };
 
-impl<'a, 'c, Tree: 'static + MerkleTreeTrait, G: 'static + Hasher> PoRep<'a, Tree::Hasher, G>
+impl<'a, Tree: 'static + MerkleTreeTrait, G: 'static + Hasher> PoRep<'a, Tree::Hasher, G>
     for StackedDrg<'a, Tree, G>
 {
     type Tau = Tau<<Tree::Hasher as Hasher>::Domain, <G as Hasher>::Domain>;

storage-proofs-post/src/election/circuit.rs

@@ -29,11 +29,11 @@ pub struct ElectionPoStCircuit<Tree: MerkleTreeTrait> {
 #[derive(Clone, Default)]
 pub struct ComponentPrivateInputs {}
 
-impl<'a, Tree: MerkleTreeTrait> CircuitComponent for ElectionPoStCircuit<Tree> {
+impl<Tree: MerkleTreeTrait> CircuitComponent for ElectionPoStCircuit<Tree> {
     type ComponentPrivateInputs = ComponentPrivateInputs;
 }
 
-impl<'a, Tree: 'static + MerkleTreeTrait> Circuit<Fr> for ElectionPoStCircuit<Tree> {
+impl<Tree: 'static + MerkleTreeTrait> Circuit<Fr> for ElectionPoStCircuit<Tree> {
     fn synthesize<CS: ConstraintSystem<Fr>>(self, cs: &mut CS) -> Result<(), SynthesisError> {
         let comm_r = self.comm_r;
         let comm_c = self.comm_c;

storage-proofs-post/src/rational/circuit.rs

@@ -23,11 +23,11 @@ pub struct RationalPoStCircuit<Tree: MerkleTreeTrait> {
 #[derive(Clone, Default)]
 pub struct ComponentPrivateInputs {}
 
-impl<'a, Tree: MerkleTreeTrait> CircuitComponent for RationalPoStCircuit<Tree> {
+impl<Tree: MerkleTreeTrait> CircuitComponent for RationalPoStCircuit<Tree> {
     type ComponentPrivateInputs = ComponentPrivateInputs;
 }
 
-impl<'a, Tree: 'static + MerkleTreeTrait> Circuit<Fr> for RationalPoStCircuit<Tree> {
+impl<Tree: 'static + MerkleTreeTrait> Circuit<Fr> for RationalPoStCircuit<Tree> {
     fn synthesize<CS: ConstraintSystem<Fr>>(self, cs: &mut CS) -> Result<(), SynthesisError> {
         let comm_rs = self.comm_rs;
         let comm_cs = self.comm_cs;

storage-proofs-post/src/rational/compound.rs

@@ -149,7 +149,7 @@ where
     }
 }
 
-impl<'a, Tree: 'static + MerkleTreeTrait> RationalPoStCircuit<Tree> {
+impl<Tree: 'static + MerkleTreeTrait> RationalPoStCircuit<Tree> {
     #[allow(clippy::type_complexity)]
     pub fn synthesize<CS: ConstraintSystem<Fr>>(
         cs: &mut CS,