Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish v27 params #1158

Merged
merged 1 commit into from
Jun 7, 2020
Merged

feat: publish v27 params #1158

merged 1 commit into from
Jun 7, 2020

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

@cryptonemo
Copy link
Collaborator Author

So looking at the hashes, something seems to have gone wrong?

@cryptonemo
Copy link
Collaborator Author

cryptonemo commented Jun 7, 2020

So looking at the hashes, something seems to have gone wrong?

Oh, nevermind, it looks like that hash doesn't change based on the identifier not changing. Please sanity check that though.

@porcuquine porcuquine added the cryptocomputelab CryptoComputeLab work label Jun 7, 2020
@porcuquine
Copy link
Collaborator

As far as I can tell, this is all as expected. However, I can't parse exactly what you wrote well enough to also confirm your logic. To state mine: I expect both the digest and the CID to change — since changed file content should affect both.

porcuquine
porcuquine previously approved these changes Jun 7, 2020
@cryptonemo
Copy link
Collaborator Author

Thanks for checking, yes, I think we're seeing the same expected results. I had a minor panic earlier, but it all looked good when I tracked it down further.

I just rebased this against neptune, so I think after this is merged, we're ready for the final release PR.

@dignifiedquire
Copy link
Contributor

Looks like I would expect it to look like. The identifiers shouldn't change, unless we changed parameters of the trees

@cryptonemo cryptonemo merged commit d088e7b into master Jun 7, 2020
@cryptonemo cryptonemo deleted the v27-params branch June 8, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cryptocomputelab CryptoComputeLab work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants