feat: allow for compilation on aarch64 #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
changed the title
vmx
reviewed
Jul 8, 2020
fil-proofs-tooling/src/metadata.rs
Outdated
| @@ -109,6 +110,33 @@ impl SystemMetadata { | |||
| memory_total_bytes: memory.total().get::<uom::si::information::byte>(), | |||
| }) | |||
| } | |||
|
|
|||
| #[cfg(not(target_arch = "x86_64"))] | |||
There was a problem hiding this comment.
I personally prefer keeping the cfg() differences as small as possible. We could create a methos that returns the host, memory and the cpu_logical/physical that is shared between the new()s. This would also make it more apparent what the difference between the cfgs is. Though it''s a matter of test, hence just a comment and nothing that needs to change/blocking a merge.
There was a problem hiding this comment.
I agree this could be nicer, but I mostly wanted to get this to compile
more fixes sha2raw: update deps and enable asm by default patch ff fix compile time imports missing import move prefetch into macro fixup fil-proofs-tooling refactoring refactoring
cryptonemo
approved these changes
Jul 23, 2020
cryptonemo
reviewed
Jul 23, 2020
| @@ -25,7 +25,7 @@ chrono = { version = "0.4.7", features = ["serde"] } | |||
| memmap = "0.7.0" | |||
| bellperson = "0.9.1" | |||
| paired = "0.20.0" | |||
| fil-sapling-crypto = "0.6.0" | |||
| fil-sapling-crypto = "0.6.3" | |||
There was a problem hiding this comment.
Rust oddity, these individual patch version updates can be omitted. They don't hurt though ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on