Implement fauxrep2. #1218
Merged
Implement fauxrep2. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
force-pushed
the
feat/fauxrep-deluxe
branch
from
78d2c44
to
7b8ade3
Compare
cryptonemo
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
fauxrep2, which takes the path to an existingp_auxfile and a cache directory path. It creates and writes a newp_auxand returns the correspondingcomm_r. No replica or tree files are written, so it is the caller's responsibility to provide them (and they must match thecomm_r_lastin the providedp_aux).Caveat: totally untested. If @cryptonemo can plumb through the API, maybe @travisperson can test before we merge. I won't have time to look at this more for a little while, but this might be enough for us to gain confidence and push this through soon.