Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update range for feistel tests #1228

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Update range for feistel tests #1228

merged 1 commit into from
Jul 24, 2020

Conversation

kirk-baird
Copy link
Contributor

What has been updated

The range of the output of a feistel round should be modulus n which is strictly less than n.

@kirk-baird
Update range for feistel tests
f2e99e1 
Signed-off-by: Kirk Baird <baird.k@outlook.com>
porcuquine
porcuquine approved these changes Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@porcuquine porcuquine merged commit 079381f into filecoin-project:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

@cryptonemo cryptonemo Awaiting requested review from cryptonemo cryptonemo is a code owner

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirk-baird @porcuquine