feat: verify non-raw to raw param transitions in phase2-cli #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPeterVanNostrand
requested review from
cryptonemo and
dignifiedquire
as code owners
porcuquine
approved these changes
Aug 4, 2020
| ); | ||
| error!("{}", err_msg); | ||
| panic!("{}", err_msg); |
There was a problem hiding this comment.
Participant's may not be familiar with tmux commands, if an error occurs it's better to have the error in a sendable file rather than asking them to mess with tmux scolling to the top of the backtrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows phase2 to verify non-raw to raw contributions.