-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: phase2-cli merge command #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR description really explains nicely what it does, it would be great to have that text also in the commit message for future reference. BTW: if you put that into your commit message, it also automatically shows up as the description of the PR (in case you don't have much experience with re-writing Git commits, I'm happy to help/do it).
Things could be simplified a bit, though I wasn't sure whether this additional parsing was intentional or not. It was easier to do it, than explaining it in comments, hence I created a new PR: #1244
3294704
to
fd0408c
Compare
@vmx Thanks, I added the PR description to the commit message.
Yup, you're right. There is dead code. I have one more phase2-cli pr for a command |
@DrPeterVanNostrand This PR needs a rebase. I guess the rest of it is then ready to go (i'd merge this one first, so that you don't have to rebase yet another time, i'll rebase my "split-keys" PR after this on is merged). |
The phase2-cli 'merge' command merges large and small param files. The final phase2 participant generates small-raw params, which are converted into small-nonraw using 'phase2 convert'. Those small-nonraw params are then merged into the large initial params to produce the final 'MPCParameters' file for a circuit.
fd0408c
to
cad0dd4
Compare
The phase2-cli
merge
command merges large and small param files.The final phase2 participant generates small-raw params, which are converted into non-raw using
phase2 convert
. The final small-nonraw params are then merged into the large initial params to produce the finalMPCParameters
file for a circuit.