Remove unwrap #1260
Merged
Remove unwrap #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
previously approved these changes
Aug 18, 2020
Comment on lines
+1
to
+2
| //requires nightly, or later stable version | ||
| //#![warn(clippy::unwrap_used)] |
There was a problem hiding this comment.
This might be possible now. I haven't checked though.
There was a problem hiding this comment.
That surely isn't a blocker to get this merged.
There was a problem hiding this comment.
I think it works fine on later stable, definitely not on the toolchain we're using though. If/when we upgrade, we can add those back in. I think that's a separate discussion from this PR though.
|
I think we should merge this one soon, before it gets outdated again. |
|
@vmx Agreed. Also, related to #1261 @porcuquine Please review. |
clippy emits warning:
warning: 8 bindings with single-character names in scope
The single character names are a valid use case in this instance,
elements of an array. Elect to allow the usage; instruct clippy to
allow this lint for function `insert_8`.
Using `expect()` with a useful argument string assists when debugging. Replace all instances of `unwrap()` with `expect()`. Makes a start at resolving: #390
Using `expect()` with a useful argument string assists when debugging. Replace all instances of `unwrap()` with `expect()`. Works towards resolving: #390
We have removed all the usages of `unwrap()` in `fil-proofs-tooling\`. In order to resolve #390 instruct clippy to warn for lint `unwrap_used` for all binaries and the main library within fil-proofs-tooling.
We have removed all the usages of `unwrap()` in `filecoin-proofs\`. In order to resolve #390 instruct clippy to warn for lint `unwrap_used` for the filecoin-proofs library.
We have removed all the usages of `unwrap()` in `storage-proofs\`. In order to resolve #390 instruct clippy to warn for lint `unwrap_used` for all libraries in store-proofs.
For this round of updates, I used nightly to detect all instances, but have reverted after making sure they've been replaced.
cryptonemo
force-pushed
the
remove-unwrap
branch
from
44c55e6
to
5341376
Compare
porcuquine
approved these changes
Aug 24, 2020
eee-byte
added a commit
to eee-byte/rust-fil-proofs
that referenced
this pull request
Sep 10, 2020
* Feat: pin params to the filecoin collab cluster. (filecoin-project#1263) This cluster is way faster to ingest data. The `--local` option makes ingestion even faster (it will put the data on one peer only while adding and pin everywhere at the end). Additionally, we trigger pin requests in the main cluster (async) so that params will be replicated by those nodes too (at some point, once they finish to fetch them) from the collab cluster. * Remove unwrap (filecoin-project#1260) * build(storage-proofs): clippy allow many_single_char_names clippy emits warning: warning: 8 bindings with single-character names in scope The single character names are a valid use case in this instance, elements of an array. Elect to allow the usage; instruct clippy to allow this lint for function `insert_8`. * refactor(fil-proofs-tooling): remove all uses of unwrap() Using `expect()` with a useful argument string assists when debugging. Replace all instances of `unwrap()` with `expect()`. Makes a start at resolving: filecoin-project#390 * refactor(filecoin-proofs): remove all uses of unwrap() Using `expect()` with a useful argument string assists when debugging. Replace all instances of `unwrap()` with `expect()`. Works towards resolving: filecoin-project#390 * build(fil-proofs-tooling): set clippy lint warn for: unwrap_used We have removed all the usages of `unwrap()` in `fil-proofs-tooling\`. In order to resolve filecoin-project#390 instruct clippy to warn for lint `unwrap_used` for all binaries and the main library within fil-proofs-tooling. * build(filecoin-proofs): set clippy lint warn for: unwrap_used We have removed all the usages of `unwrap()` in `filecoin-proofs\`. In order to resolve filecoin-project#390 instruct clippy to warn for lint `unwrap_used` for the filecoin-proofs library. * build(storage-proofs): set clippy lint warn for: unwrap_used We have removed all the usages of `unwrap()` in `storage-proofs\`. In order to resolve filecoin-project#390 instruct clippy to warn for lint `unwrap_used` for all libraries in store-proofs. * - fix: manually apply phase2 unwrap changes * fix: replace all remaining usages of unwrap For this round of updates, I used nightly to detect all instances, but have reverted after making sure they've been replaced. Co-authored-by: tcharding <me@tobin.cc> * Eliminate wasteful public-input conversions. * Decompress proofs in parallel. * feat: accelerate SNARK verification (filecoin-project#1271) * feat: accelerate SNARK verification This PR integrates lotus-blst in order to accelerate the SNARK verification. This feature can be enabled with the `use_fil_blst` setting. * docs: update changelog for new release * chore(storage-proofs-core): release 5.1.2 * chore(storage-proofs-porep): release 5.1.2 * chore(storage-proofs-post): release 5.1.2 * chore(storage-proofs): release 5.1.2 * chore(filecoin-proofs): release 5.1.2 * chore(fil-proofs-tooling): release 5.1.2 * feat: accelerate SNARK verification for Window PoSt This feature can be enabled with the `use_fil_blst` setting. * chore: add log information when fil-blst is used * test: add CI for running tests with fil-blst Ideally the tests with fil-blst enabled can be run without any special flags, but for now it's good enough to run them on CI. * docs: update changelog for release * chore(storage-proofs-core): release 5.1.3 * chore(storage-proofs-porep): release 5.1.3 * chore(storage-proofs-post): release 5.1.3 * chore(storage-proofs): release 5.1.3 * chore(filecoin-proofs): release 5.1.3 * chore(fil-proofs-tooling): release 5.1.3 * Add FaultySectors error to Fallback PoSt. (filecoin-project#1274) * Add FaultySectors error to Fallback PoSt. * Test FaultySectors error with invalid PoSt. * Apply code review. Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> * docs: update changelog for release * chore(storage-proofs-core): release 5.1.4 * chore(storage-proofs-porep): release 5.1.4 * chore(storage-proofs-post): release 5.1.4 * chore(storage-proofs): release 5.1.4 * chore(filecoin-proofs): release 5.1.4 * chore(fil-proofs-tooling): release 5.1.4 Co-authored-by: Hector Sanjuan <code@hector.link> Co-authored-by: nemo <nemo@protocol.ai> Co-authored-by: tcharding <me@tobin.cc> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: porcuquine <1746729+porcuquine@users.noreply.github.com> Co-authored-by: Volker Mische <volker.mische@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #1122, as a lot of code has changed since then