Eliminate wasteful PoR public-input conversions. #1267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid needless intermediate conversions to/from
Vec<bool>
when convertingusize
toVec<bool>
. Current public input representation for thePoR
circuit trivially encodes challenges as the correspondingFr
, so nothing more is required.NOTE: when we do pack more efficiently, it will not be necessary to restore the logic replaced here. Then we can use bit-shifting (
<<
) and bitwise or (|
) (or+
) to keep input generation cheap. [EDIT: We will not be able to use a simple conversion fromu64
then — and thetry_from
used here is meant as a reminder not to. Instead, we will need a way to assemble an appropriateFrRepr
directly. Alternately, we can trade some performance for simplicity and build up the result withFr
operations on individual challenges.]Hat tip to @simonatsn and @sean-sn for observing the waste.