Decompress proofs in parallel. #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
requested review from
cryptonemo and
dignifiedquire
as code owners
cryptonemo
previously approved these changes
Sep 1, 2020
porcuquine
force-pushed
the
opt/parallel-proof-decompression
branch
from
9c9e301
to
866d8d2
Compare
cryptonemo
previously approved these changes
Sep 1, 2020
porcuquine
force-pushed
the
opt/parallel-proof-decompression
branch
from
866d8d2
to
4177aac
Compare
cryptonemo
previously approved these changes
Sep 1, 2020
porcuquine
force-pushed
the
opt/parallel-proof-decompression
branch
from
4177aac
to
ba68163
Compare
cryptonemo
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of decompressing as we read proofs, first read them all into a buffer and decompress in parallel.
Thanks to @simonatsn and @sean-sn for noticing and submitting an improvement (adapted here).